-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D3D12] Improve shader validation handling. #88254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm only wondering if whether dev mode is enabled should be part of the shader cache key. Otherwise, I think you can lock yourself up in non-validated shaders if you eventually disable dev mode, until the cache is invalidated for some reason.
I have already added it to the |
Needs rebase after #87340. |
Rebased, also added a few minor fixes for MinGW build, which was broken by #87340. |
Oh, it's just that I reviewed this late, on my phone, and I missed that part. My apologies. |
Thanks! |
Depends on godotengine/godot-nir-static#8