Disable signal callback generation in C#

[paulloz]

A while ago, we talked about disabling the signal callback generation altogether for C# until we have a better implementation. Reasons are, it currently generates the method outside the class (creates compilation error, obviously), and the behaviour is weirdly inconsistent depending on how you have external editors configured.

To prevent confusion like "the dialog didn't do the thing", I added a small message in the connection window, depending on the language of the script. Not sure if this is wanted, let me know (also, the message itself probably kinda sucks, feel free to suggest something better).

Bugsquad edit:

• Works around / fixes New signal methods in C# are declared outside of its class, making the script invalid #18721.

[zaevi]

Looks good to me👍

[AThousandShips]

LGTM code wise

[Calinou]

Until we find a better workaround for this (such as displaying the code you should copy in a read-only TextEdit), this is probably for the better.

[raulsntos]

I feel a bit hesitant about adding new API to ScriptLanguage. I don't know if there are Script languages other than C# that would make use of this, adding this just for C# knowing that C# will eventually move away from the ScriptLanguage API feels wrong.

But if the area maintainers are fine with this, then I do think this is an improvement over the current state for C#.

[paulloz]

I feel a bit hesitant about adding new API to ScriptLanguage. I don't know if there are Script languages other than C# that would make use of this, adding this just for C# knowing that C# will eventually move away from the ScriptLanguage API feels wrong.

I had a similar feeling. We could simply always return an empty string and not display anything to the user. It'd be a bit worse UX, but still better than the current state, IMHO. In that case, I'd still modify the add_callback logic to not overwrite the file if make_function returns a string of length zero...

[akien-mga]

I think it's fine to add this method. It does feel very specific, but find_function and make_function do too and they're already part of the API. Having a boolean check to control the user of those two methods doesn't seem too far fetched.

[raulsntos]

LGTM. Thanks!

[akien-mga]

Thanks!

[dayo05]

I have a question about this: is this breaks custom signal registration by code as introduced on docs?

[paulloz]

I have a question about this: is this breaks custom signal registration by code as introduced on docs?

Hello! No, this only blocks the editor to write the empty method in your .cs file when you connect a signal to an inexistent method from Godot's UI.