Only recurse depth wise in Tree::_count_selected_items
#87943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
This looks correct to me, it's only called internally (and only once) and on the root, so no nodes will be missed, using iteration over recursion for this won't change the outcome as the order isn't relevant
On the topic of using a stack or similar there's always benefits and drawbacks to either, and I believe largely trees will be wide and not deep so it's low risk, and we do a lot of other processes here recursively so any changes would best be done in a bigger rework 🙂
AThousandShips
added
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation for
Tree::_count_selected_itemsrecurses on both depth and width. This very quickly leads to a stackoverflow. I noticed this in the integratedFileDialogwhich would crash when opening folders with a lot of files.The new implementation only recurses on depth and iterates on width. Ideally it probably shouldn't recurse at all but I didn't know if std::stack was permitted to use and I guess a
Treeshouldn't ever be deep enough to lead to a stack overflow here anyways.