Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Callable call_deferred() C# example #87928

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add Callable call_deferred() C# example #87928

merged 1 commit into from
Feb 5, 2024

Conversation

31
Copy link
Contributor

@31 31 commented Feb 4, 2024

Callable.From(...).CallDeferred(); helps keep type safety in C# vs. using GodotObject's StringName-based call_deferred. Add a C# example to call_deferred to avoid people seeing this as a GDScript-only feature.

@31 31 requested a review from a team as a code owner February 4, 2024 04:55
@raulsntos raulsntos added this to the 4.3 milestone Feb 4, 2024
raulsntos
raulsntos approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@akien-mga akien-mga merged commit 8631f68 into godotengine:master Feb 5, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@31 31 deleted the dev/31/call-deferred-cs branch February 8, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:dotnet
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@31 @akien-mga @raulsntos