Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D normals for transposed texture #87225

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Fix 2D normals for transposed texture #87225

merged 1 commit into from
Jan 22, 2024

Conversation

kleonc
Copy link
Member

@kleonc kleonc commented Jan 15, 2024

Fixes #87157.

Before
v4.3.dev2.official [3524346]		 After
(this PR)
bP9ynTQLKj godot windows editor dev x86_64_NUgdIIcntX

Shader used:

shader_type canvas_item;
void fragment() {
	COLOR = vec4(NORMAL.xy * vec2(0.5, -0.5) + vec2(0.5), 1.0, 1.0);
}

@kleonc kleonc added this to the 4.3 milestone Jan 15, 2024
@kleonc kleonc requested a review from clayjohn January 15, 2024 16:46
@kleonc kleonc requested a review from a team as a code owner January 15, 2024 16:46
clayjohn
clayjohn approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@YuriSizov YuriSizov merged commit bf94131 into godotengine:master Jan 22, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@kleonc kleonc deleted the transposed-texture-fix-2d-normals branch January 22, 2024 21:57
@kleonc
Copy link
Member Author

kleonc commented Jan 22, 2024

Should be fine for cherry-picking.

@kleonc kleonc added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 22, 2024
@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:2d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Rotating Tiles with normalmaps don't rotate the normals as well.
3 participants
@kleonc @YuriSizov @clayjohn