C#: Enforce globalization code quality rules #87133
Conversation
Repiteo
force-pushed
the
dotnet/enforce-globalization-rules
branch
from
4eb5094
to
4b27844
Compare
Repiteo
force-pushed
the
dotnet/enforce-globalization-rules
branch
4 times, most recently
from
ff9b22a
to
3106289
Compare
modules/mono/glue/GodotSharp/GodotSharp/Core/StringExtensions.cs
Outdated
Show resolved
Hide resolved
Repiteo
force-pushed
the
dotnet/enforce-globalization-rules
branch
from
3106289
to
7236dfe
Compare
| @@ -1329,7 +1330,7 @@ public static bool HtmlIsValid(ReadOnlySpan<char> color) | |||
| /// <returns>A string representation of this color.</returns> | |||
| public readonly string ToString(string? format) | |||
| { | |||
| return $"({R.ToString(format)}, {G.ToString(format)}, {B.ToString(format)}, {A.ToString(format)})"; | |||
| return $"({R.ToString(format, null)}, {G.ToString(format, null)}, {B.ToString(format, null)}, {A.ToString(format, null)})"; | |||
There was a problem hiding this comment.
Ditto for Plane, Projection, Quaternion, Vector2, Vector2I, Vector3, Vector3I, Vector4, Vector4I.
Do we really want to use the current culture instead of invariant here? E.g. on my machine, this would represent floating points as 3,1415927, it feels wrong compared to 3.1415927. I think we should default to CultureInfo.InvariantCulture.NumberFormat instead.
There was a problem hiding this comment.
While I agree, this was to the end of keeping the previous behavior intact. Plus, we'd probably want a way to change the culture if we're changing the default, which would be outside the scope of this PR. I'm implementing something similar in a seperate PR via IFormattable (#83159), so this default could be applied there instead
Alternatively, if everyone is onboard with making it CultureInfo.InvariantCulture.NumberFormat, I'm completely fine with applying that instead. Just a matter of gauging the other contributors' thoughts
Repiteo
force-pushed
the
dotnet/enforce-globalization-rules
branch
from
7236dfe
to
000d12d
Compare
|
Thanks! |
Implements globalization code quality rules1. Also, removed the relevant
.editorconfigsuppressions of these warnings, as they're now accounted for and should be warned of moving forward.Footnotes
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/globalization-warnings ↩