Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for C# diagnostic analyzers #86528

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

avilches
Copy link
Contributor

This PR adds test cases for the analyzers in the Godot.SourceGenerators.Tests project, following the same spirit as @paulloz did on #82955.

  • MustBeVariantAnalyzer
  • GlobalClassAnalyzer

Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for working on this, and sorry it took me this long to review.

@raulsntos raulsntos modified the milestones: 4.x, 4.3 Jan 10, 2024
@avilches avilches force-pushed the must-be-variant-tests branch 2 times, most recently from eb14c80 to 13f1010 Compare January 15, 2024 10:10
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@YuriSizov YuriSizov merged commit 7351b57 into godotengine:master Jan 17, 2024
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants