-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add obj importer changes to use ImporterMesh. #86365
Conversation
ea3baaa
to
5a423ce
Compare
Instead of converting from ImporterMesh to ArrayMesh using get_mesh(). In my next revision I will use a boolean that defaults to off to swtich between ImporterMesh and ArrayMesh |
1ab4b7b
to
c0b1270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me! I tested it and it works. Thanks @fire!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect!
Thanks! |
When importing the same OBJ file 10 times, this seems to be slightly slower when comparing optimized builds together between The difference isn't dramatic so this is probably within acceptable bounds, especially if it helps resolve bugs and make code maintenance easier in the future. Testing project: test_obj_import.zip (make 10 copies of
|
Cherry-picked for 4.2.2. |
Fixes: godotengine/godot-proposals#8600
Note: this switches the ImporterMesh round tripping to be on the common track and not on the niche track.