Fix get_used_rect, get_used_cells and get_used_cells_by_id in TileMap after a call to clear()
#83890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap after a call to clear()
smix8
approved these changes
Oct 24, 2023
akien-mga
changed the title
akien-mga
changed the title
get_used_rect, get_used_cells and get_used_cells_by_id in TileMap after a call to clear()
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the 4.2 TileMap refactor, the
tile_mapdata structure could contain an invalid ID before they get cleaned up at the end of the frame.This made it so
get_used_rect,get_used_cellsandget_used_cells_by_idwould return wrong results just after some cells got deleted.This PR adds a check to avoid counting invalid tiles to compute de result of those functions.