Fix Scene Importer crashing when animation or mesh save paths are invalid #83856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
the
cherrypick:4.1
|
Didn't realize the fix was as integrated with the other PR as it was, but still works as a separate PR, though might get merged alone if approved as it superseeds the other one |
YuriSizov
added
the
cherrypick:4.2
BlueCube3310
force-pushed
the
animation-import-crash
branch
from
0cab479
to
419822e
Compare
BlueCube3310
force-pushed
the
animation-import-crash
branch
from
419822e
to
ae76bb7
Compare
BlueCube3310
changed the title
BlueCube3310
force-pushed
the
animation-import-crash
branch
from
ae76bb7
to
cd87916
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:4.1
|
Cherry-picked for 4.2.2. |
akien-mga
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79145.
Supersedes #80017.
Adds an additional check to the Advanced Scene Import settings to ensure the meshes and animations are to be saved in existing directories. Now, if any of the save paths are invalid, the whole file will fail to import with an error instead.