[macOS] Fallback to native OpenGL renderer if ANGLE initialization failed. #83753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iled. Remove platform specific renderer config values from docs.
akien-mga
approved these changes
Oct 31, 2023
|
Thanks! |
|
This actually might need some extra check, it's only checking for EGL init, which will probably always succeed with static build, so it probably should at least try opening display. Will do a follow-up soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove platform specific renderer config values from docs.
Should fix compatibility mode init crashing on old macOS versions or hardware with missing Metal support. Fallback is enabled by default and can be overridden with
rendering/gl_compatibility/fallback_to_nativeproject setting.