Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Disable "Activate now" when creating addons #83578

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

raulsntos
Copy link
Member

Since C# is a compiled language and doesn't support activating the plugin immediately after creating it, the "Activate now" option is disabled and a warning explains why.

Since C# is a compiled language and doesn't support activating the plugin immediately after creating it, the "Activate now" option is disabled and a warning explains why.
@HexBlit
Copy link

HexBlit commented Feb 4, 2024

A future enhancement would be to maybe have a deferred activate, so that when it does compile the set active button is enabled, and if was set to true it can be truly enabled post compilation instead of having the dev worry about activating the plugin and compilation dependencies.

Copy link
Contributor

@ryevdokimov ryevdokimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After:

image

@akien-mga akien-mga modified the milestones: 4.x, 4.3 Feb 19, 2024
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. I assume it's not an option to force compile the new plugin script so that the activation works?

@akien-mga akien-mga merged commit 49e0d81 into godotengine:master Feb 19, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the dotnet/disable-activate-now branch February 19, 2024 16:43
@raulsntos
Copy link
Member Author

I assume it's not an option to force compile the new plugin script so that the activation works?

Well, the plugin hasn't been written yet so it wouldn't accomplish much. You'd still have to write the plugin, re-build the project, and then re-enable the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants