Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter shader node not declared when only connected to a VaryingSetter #83189

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix parameter shader node not declared when only connected to a VaryingSetter #83189

merged 1 commit into from
Oct 13, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #75735

But the code looks like intentional, this commit might break things. CC @Chaosus

@jsjtxietian jsjtxietian marked this pull request as ready for review October 12, 2023 09:59
@jsjtxietian jsjtxietian requested a review from a team as a code owner October 12, 2023 09:59
Chaosus
Chaosus approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@Chaosus Chaosus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember that part of code now, if it fixes the bug LGTM.

@Chaosus Chaosus added this to the 4.2 milestone Oct 12, 2023
@akien-mga akien-mga merged commit 8f98f13 into godotengine:master Oct 13, 2023
15 checks passed
@jsjtxietian jsjtxietian deleted the fix-shader-node-parameter-connect-to-vary-error branch October 13, 2023 09:53
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaosus Chaosus Chaosus approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Visual Shader not declaring a parameter when the nodes are only connected to a VaryingSetter
3 participants
@jsjtxietian @akien-mga @Chaosus