Fix external editor hot reload for GDScript

[OmarShehata]

Fixes #72825 by adding a call to:

ScriptEditor::get_singleton()->trigger_live_script_reload();

in the GDScriptTextDocument::didSave callback. I tested this using the VSCode Godot extension, when connected to the language server, in master saving the file in VSCode does NOT trigger an update. An update only happens when you focus in the editor, which goes through the flow: ScriptEditor::_notification -> _update_modified_scripts_for_external_editor().

https://github.com/godotengine/godot/blob/6916349697a4339216469e9bf5899b983d78db07/editor/plugins/script_editor_plugin.cpp#L1677C4-L1677C48

For reference, the normal flow of updating a script file while the game is running goes through ScriptEditor::_res_saved_callback() -> _trigger_live_script_reload()

[pchan3]

@OmarShehata

I am currently using Jetbrains Rider & C#. The issue I experience is that If I have a Node open in the editor with a C# script attached. Make a change in Rider to the script & save. Then make a change to an export variable in the inspector and then save. The behaviour is that the script reverts and Rider does a hot reload and I lose my changes.

I have compiled this particular PR and I am able replicate the bug in it.

Is this PR catering for my scenario or is my issue different?

[akien-mga]

Looks good to me.

[akien-mga]

@pchan3 This PR only changes things for the GDScript LSP, not for C# editors.

[pchan3]

@pchan3 This PR only changes things for the GDScript LSP, not for C# editors.

Should I raise this as a new bug?

[akien-mga]

@pchan3 I believe your issue is already tracked here: #50163

[akien-mga]

Thanks!

[muhajirdev]

is this already in the latest beta @OmarShehata , how do I try it?