Fix bugs of copying scene root node or pasting node as scene root #81415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Sep 7, 2023
Rindbee
force-pushed
the
fix-copy-or-paste-root-nodes
branch
from
bba59d0 to
93dd0c0
Compare
timothyqiu
reviewed
Sep 7, 2023
Fix crash when pasting a node as a new scene root. Fix owner was not set correctly when copying scene root node from unsaved scene. The owner of the root node is `nullptr`, which was ignored before.
Rindbee
force-pushed
the
fix-copy-or-paste-root-nodes
branch
from
93dd0c0 to
95248a7
Compare
KoBeWi
approved these changes
Sep 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash when pasting a node as a new scene root.
Fix owner was not set correctly when copying scene root node from unsaved scene.
The owner of the root node is
nullptr, which was ignored before.Bugsquad edit: Fixes #81507