Fix double unregistration on dispose of Array.

[SamiKalliomaki]

This fixes a small bug where Array tries to unregister itself twice on shutdown.

I have tested this manually and the error is no longer logged on shutdown.

• Bugsquad edit, fixes: Array - System.ArgumentException: Disposable not registered. (Parameter 'weakReference') on shutdown #81231

[SamiKalliomaki]

I just realized my initial pull request description was nonsense. There is no recursion going on and we can skip the temporary variable.

[SamiKalliomaki]

Based on the investigation in the bug, update the PR to instead avoid double registration that seems to be the root cause of the issue.

[raulsntos]

Thanks! I read the explanation in #81231 (comment) and I understand what's going on now, I've been able to reproduce the issue and this looks like the correct fix.

It seems we can also remove : this() from the Array<T> constructor that takes T[] array. Although I don't think this one causes any issues, but we can save allocating Array twice:

https://github.com/godotengine/godot/blob/5b2972b57412722fd89737291aff67eaefd1a172/modules/mono/glue/GodotSharp/GodotSharp/Core/Array.cs#L1060

Also, since you are a new contributor, make sure to read CONTRIBUTING.md and the contributing documentation if you haven't already.

You'll need to squash the commits before this PR can be merged. The contributing documentation contains information about squashing in case you need it.

Feel free to reach out in the development chat if you need help.

[SamiKalliomaki]

I've squashed the commits as well as removed the one extra "this()" call from the generic version of the Array class.

[raulsntos]

LGTM.

[akien-mga]

Thanks!

[YuriSizov]

Cherry-picked for 4.1.2.