Fallback to linear color texture when using 2D HDR and MSDF font #80651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 15, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #80646
The issue here came from the fact that, when using HDR rendering, Godot uses the "srgb" variant of the color texture. The srgb-variant ensures that the GPU does an srgb->linear conversion when the texture is read in the shader.
This causes problems when we use the color texture to pass in a texture that does not contain colors (like with MSDF textures). When a texture does not contain colors, we should not do any color space conversions at all.
This PR introduces a flag that can be used to ensure that the normal (non-srgb) texture variant is used.
No need to cherrypick as this relates to a new feature