GLTF: Improve logic for keeping track of the real root node #80272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
gltf-root-node-logic
branch
from
a18e9a1
to
f1dd9cb
Compare
This was referenced Aug 20, 2023
aaronfranke
force-pushed
the
gltf-root-node-logic
branch
from
f1dd9cb
to
5b7001d
Compare
adamscott
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
Reviewed during the #animation/#asset-pipeline meeting. This should be considered a bug fix, because the logic it changes was plain wrong (wrong order of calls). Discussed about compatibility breaking, it would break compatibility in some cases if you have a node name that matches the GLTF scene name (which rarely happens).
We need to document the breaking compatibility.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the logic for keeping track of the real root node. There is now a method called
_generate_scene_node_treewhich is the parent method that generates a single root node, and generates nodes under it (starting with the GLTF root nodes). In the current master, the GLTF importer fishes out the real root node by grabbing a GLTF root node and then getting its parent, super janky.