Enable depth writes during shadow pass and depth pass. Disable during color pass #80070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… color pass This fixes an unreported performance bug. Basically, without this change, the depth prepass did nothing
clayjohn
added
bug
topic:rendering
performance
cherrypick:4.1
BastiaanOlij
approved these changes
Jul 30, 2023
|
Thanks! |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an unreported performance bug. Basically, without this change, the depth prepass did nothing
Tested with #68959 and verified the results in Renderdoc.
Performance without this change: 22 ms per frame
With this change: 18 ms per frame
Same scene in 3.5.1: 18 ms per frame