Validate another case of using DATA_FORMAT_A2B10G10R10_UNORM_PACK32 texture with storage flag #72068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exture with storage flag
akien-mga
approved these changes
Jan 26, 2023
|
Thanks! |
This was referenced Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix: #67430
Follow up to #71939
This time I went through every usage of
TEXTURE_USAGE_STORAGE_BITto see if it was possible that it could be called with a texture format that is not guaranteed by the Vulkan spec.I found two places where it could happen. One is here, and it is likely the condition that OP is hitting. This is a branch that only runs when
rendering/reflections/sky_reflections/texture_array_reflectionsis false.The other is when using the CanvasItem screen SDF. It requests a R16G16_UINT texture with the storage flag, but that also requires the
shaderStorageImageExtendedFormatsfeature. We need to implement a fallback for that so it falls back to an R16G16B16A16_UINT texture on such devices (or R32G32_UINT), but that will take a bit of refactoring and is better left for another PR