Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS: Remove project_path VCS property, let plugins decide #70353

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

twaritwaikar
Copy link
Contributor

@twaritwaikar twaritwaikar commented Dec 20, 2022

Screenshots:

On a completely new repo (no .git directory in current or parent paths)

image

On a seasoned repo (parent path has a .git directory)

image

This PR was made in parallel with - twaritwaikar/godot-git-plugin#1

The project path is no longer required because if the plugin can self-identify the project directory, then there is no need for the user to customize this behaviour. Using a bad project path will result in frustrating errors since we expect the plugin to work the same way as the git CLI.

@twaritwaikar
Copy link
Contributor Author

twaritwaikar commented Dec 21, 2022

Can be cherrypicked to 3.x
I will backport this to 3.x

@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants