Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary namespaces in generated PropertyDefVal files. #69278

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Remove unnecessary namespaces in generated PropertyDefVal files. #69278

merged 1 commit into from
Nov 30, 2022

Conversation

rhofour
Copy link
Contributor

@rhofour rhofour commented Nov 28, 2022

These namespaces are no longer needed after #68580 was merged.

@rhofour rhofour requested a review from a team as a code owner November 28, 2022 03:08
@rhofour rhofour marked this pull request as draft November 28, 2022 03:11
@neikeq
Copy link
Contributor

neikeq commented Nov 28, 2022

Is that PR truly the reason those namespaces are no longer needed? My guess is that it would be because of #69088.

@rhofour rhofour marked this pull request as ready for review November 30, 2022 03:13
@rhofour
Copy link
Contributor Author

rhofour commented Nov 30, 2022

@neikeq I think the root of it was #68580. Before that those namespaces were needed because most people didn't fully qualify their types.

#69088 fixes a bug #68580 introduced.

@akien-mga akien-mga added this to the 4.0 milestone Nov 30, 2022
@neikeq neikeq added enhancement and removed bug labels Nov 30, 2022
@neikeq neikeq merged commit 6745e19 into godotengine:master Nov 30, 2022
@neikeq
Copy link
Contributor

neikeq commented Nov 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikeq neikeq neikeq approved these changes

Assignees
No one assigned
Labels
enhancement topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rhofour @neikeq @akien-mga