Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all lossless image formats to be used for VRS texture project setting #68836

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 18, 2022

WebP can also be lossy, but the class reference now warns about the requirement to use a lossless format for the VRS texture to work correctly.

Viewport's vrs_texture property already allows any image format to be used, as it requests a Texture2D resource type instead of a file path. Project settings only store a file path though, not the actual resource file.

@Calinou Calinou requested a review from a team as a code owner November 18, 2022 15:30
@Calinou Calinou added this to the 4.0 milestone Nov 18, 2022
@Calinou Calinou force-pushed the projectsettings-vrs-texture-allow-more-formats branch from f6b8210 to cb3b78c Compare November 18, 2022 21:18
@Calinou Calinou requested a review from a team as a code owner November 18, 2022 21:18
@Calinou Calinou force-pushed the projectsettings-vrs-texture-allow-more-formats branch from cb3b78c to 25de0a8 Compare November 18, 2022 21:21
…etting

WebP can also be lossy, but the class reference now warns about the
requirement to use a lossless format for the VRS texture to work correctly.
@Calinou Calinou force-pushed the projectsettings-vrs-texture-allow-more-formats branch from 25de0a8 to 4b13093 Compare November 18, 2022 21:21
@akien-mga akien-mga merged commit f4faa50 into godotengine:master Nov 28, 2022
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the projectsettings-vrs-texture-allow-more-formats branch November 28, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants