Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to includes in core data structures #66962

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

aaronfranke
Copy link
Member

@aaronfranke aaronfranke commented Oct 6, 2022

These changes fix things I noticed while working on syncing up the engine's data structures and godot-cpp.

  • Prefer forward-declaring String and Vector instead of including them where possible.
  • Only include what's needed (ex: Vector4 does not need Vector3, it was a blind copy/paste from Quaternion).
    • Due to this, Vector is no longer implicitly included in Transform3D, so add an explicit one.
  • Add missing _NO_DISCARD_ to Projection.
  • Add some explicit (real_t) casts (for consistency with godot-cpp's Math::min requirements).
  • Some spacing and comment tweaks.

@aaronfranke aaronfranke added this to the 4.0 milestone Oct 6, 2022
@aaronfranke aaronfranke requested a review from a team as a code owner October 6, 2022 04:42
@akien-mga akien-mga merged commit e727606 into godotengine:master Oct 6, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants