Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind PhysicsDirectBodyState3D::get_inverse_inertia_tensor #66936

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Bind PhysicsDirectBodyState3D::get_inverse_inertia_tensor #66936

merged 1 commit into from
Oct 6, 2022

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Oct 5, 2022

Related to #65465 and #65571.

Currently when you try to create a GDExtension that provides a custom physics server (along with a PhysicsDirectBodyState3DExtension), you'll get an error saying:

servers\extensions\physics_server_3d_extension.h:59 - Required virtual method SomeExtendedDirectBodyState::_get_inverse_inertia_tensor must be overridden before calling.

There is however no such method to implement in PhysicsDirectBodyState3DExtension. This seems to be due to some bindings missing for PhysicsDirectBodyState3D and PhysicsDirectBodyState3DExtension.

This PR addresses that problem and will allow you to actually override/implement PhysicsDirectBodyState3DExtension::_get_inverse_inertia_tensor once the godot-cpp headers have been updated.

@mihe mihe requested review from a team as code owners October 5, 2022 15:53
@akien-mga akien-mga added this to the 4.0 milestone Oct 5, 2022
@akien-mga akien-mga merged commit 61021c0 into godotengine:master Oct 6, 2022
@akien-mga
Copy link
Member

akien-mga commented Oct 6, 2022

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants