Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mobile as the default rendering method on mobile when Vulkan is supported #66637

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

clayjohn
Copy link
Member

This fixes an oversight from #65541. When I renamed the project settings I forget to set the default mobile renderer to the mobile renderer. This resulted in an unexpected performance decrease for mobile users as they are suddenly using the clustered renderer without warning.

@clayjohn clayjohn added this to the 4.0 milestone Sep 30, 2022
@clayjohn clayjohn requested a review from a team as a code owner September 30, 2022 02:18
@akien-mga
Copy link
Member

akien-mga commented Sep 30, 2022

You forgot the docs ;)

@akien-mga
Copy link
Member

It's worth noting that this probably won't work for the Android editor and Web editor due to this: #64100

But I think I'll fix #64100 eventually even if reduz believes overrides shouldn't be applied in the editor, I think we have enough proof that they're needed.

@akien-mga akien-mga requested a review from a team as a code owner September 30, 2022 07:57
@akien-mga akien-mga merged commit a0d1738 into godotengine:master Sep 30, 2022
@akien-mga
Copy link
Member

Thanks!

@clayjohn clayjohn deleted the mobile-renderer branch September 30, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants