Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EditorTheme: Remove rounded corners for all popups #65256

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

RedMser
Copy link
Contributor

@RedMser RedMser commented Sep 2, 2022

Closes #65231

Expands the solution of #59045 to apply to all kinds of popups (including tooltips), since they all render as separate windows and have the same issue with per-pixel transparency.

Expands godotengine#59045 to apply to all kinds of popups,
since they all render as separate windows.
@Calinou Calinou added this to the 4.0 milestone Sep 2, 2022
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if per-pixel transparency will work on all platforms/rendering drivers, it has some performance impact. So this is probably a better solution anyway.

@Calinou
Copy link
Member

Calinou commented Sep 2, 2022

Even if per-pixel transparency will work on all platforms/rendering drivers, it has some performance impact. So this is probably a better solution anyway.

Also, it should be noted that per-pixel transparency doesn't work if you have compositing disabled on X11 (like I do for performance reasons). So I agree it's best not to rely on it in the editor itself.

@akien-mga akien-mga merged commit 18ee0da into godotengine:master Sep 2, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small transparency(?) issue on the corners of tooltips.
4 participants