Don't use rounded corners for PopupMenus in the editor theme #59045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't the window background color be changed to use the border color instead? That would allow the inner section of the window to have rounded corners while still fixing the corner pixels. |
|
tbh I also prefer the non rounded look on these popups, they aren't normal windows after all. |
YuriSizov
approved these changes
Aug 18, 2022
|
To address the suggestion above, this could work, but I like this PR as an immediate fix. We can experiment more later. |
PopupMenus use separate windows by default in the editor, and windows no longer support per-pixel transparency for now in 4.0. Even if per-pixel transparency was reimplemented, we can't assume that it'll always work in practice (e.g. when compositing is disabled).
Calinou
force-pushed
the
editor-theme-popup-no-rounded-corners
branch
from
d25dfce to
ce8b402
Compare
|
Rebased and tested again, it works as expected. |
mhilbrunner
approved these changes
Aug 18, 2022
|
Thanks! |
RedMser
added a commit
to RedMser/godot
that referenced
this pull request
Sep 2, 2022
Expands godotengine#59045 to apply to all kinds of popups, since they all render as separate windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PopupMenus use separate windows by default in the editor, and windows no longer support per-pixel transparency for now in 4.0. Even if per-pixel transparency was reimplemented, we can't assume that it'll always work in practice (e.g. when compositing is disabled).
This closes #56009.
Preview
Scaled to 400% with nearest-neighbor filtering.
Before
After