Prefix shader uniforms with "shader_parameter/".

[nathanfranke]

This may have been a regression from #62972
Assuming this is not intentional, since shader uniforms like shader collide with existing properties, causing an invalid state.

CC @Chaosus

Correctly fixed the properties on my project, although note shader params set between the merge of #62972 and this PR won't be auto corrected. These are now also corrected for.

[Chaosus]

Did you test group uniforms with that fix?

[nathanfranke]

Ah, good idea. Almost works, but I think I need to add the hint string for all generated groups:

Edit: Corrected

[TokisanGames]

note shader params set between the merge of #62972 and this PR won't be auto corrected.

Does this mean materials created within the last 3 weeks and counting, (since this isn't merged yet) will be broken again after this is merged? I have over 400 materials and have been porting my project during the last 3 weeks. The current materials have no shader_param/ prefix, so there's nothing to search and replace. Why isn't this PR extended to read the current working parameters for backwards compatibility. There's already backward compatible code in there. The extension code could be taken out once gd4 hit stable.

[nathanfranke]

@tinmanjuggernaut Added compatibility code.

Once this PR is merged, I'll make a follow-up draft PR to remove the legacy compatibility (I propose removing both "param/" and "" prefixes).

[akien-mga]

This will likely need to be changed after #64952.

[TokisanGames]

I'd introduce a deprecated phase. Get all the renames in by beta. All old names still work, but are deprecated, and are documented as such. Then they'll be removed by 4.0, or 4.1. 4.0 isn't going to be any time soon, so might be fine as long as it's clearly communicated.

The problem isn't the renames so much, it is the lack of documentation noting the changes in a centralized place, attached to each changing PR. Us game devs just get to "discover" the renames when our project doesn't work. Each is an unpleasant surprise.

[Zireael07]

Yep, and a dedicated documentations page listing changes in ONE place. I've been using the mega-ass renames tracker on GitHub, but even that misses some...

[Calinou]

Yep, and a dedicated documentations page listing changes in ONE place. I've been using the mega-ass renames tracker on GitHub, but even that misses some...

This is already planned: godotengine/godot-docs#4960

I suppose we can generate a reStructuredText table with all renames based on the 3to4 conversion code. Some notes will also need to be manually written at the top of the page, as some things can't be converted automatically.

[TokisanGames]

That conversion code is incomplete. Doesn't even touch shaders for instance, and there's countless more things lacking.

[akien-mga]

This can now be rebased.

[clayjohn]

This looks good to me. But I am unfamiliar with this system. Would be good to have approval from @Chaosus

[Chaosus]

The category "Shader Uniforms" for the instance uniforms should be renamed:

so the tweener code should looks like:
create_tween().tween_property(child, "shader_parameter/test", Vector3(1, 0, 0), 1.0) instead of create_tween().tween_property(child, "shader_uniforms/test", Vector3(1, 0, 0), 1.0)

[Chaosus]

nvm, it can be done later ^^ I think it's good for now

[akien-mga]

Thanks!