Implement shader uniform groups/subgroups

[Chaosus]

Implement uniform groups using syntax like:

uniform_group MyUniformGroup {
// ... uniforms
	  uniform_group MyUniformSubGroup {
	   // ... uniforms
	  };
};

Example screenshot:

Intended to close part of godotengine/godot-proposals#4827. If this is accepted I would like to try to implement them to visual shader to close it completly but not for now.

[akien-mga]

I noticed that within a group the uniforms are listed alphabetically, is that intended?
In GDScript exports are listed in the order they're defined in the script, which allows to give them a meaningful order.

[Chaosus]

I noticed that within a group the uniforms are listed alphabetically, is that intended? In GDScript exports are listed in the order they're defined in the script, which allows to give them a meaningful order.

It's not related to this PR, it's because uniforms originally placed to HashMap(with alphabetial sorting) instead of a Vector.

[Calinou]

We should probably update the shader style guide to mention recommended casing:

uniform_group SomeGroup {
	// ...
}

Or:

uniform_group some_group {
	// ...
}

I'd go for snake_case personally, as the editor's automatic capitalization will probably do a better job with it.

[AaronRecord]

We should probably update the shader style guide to mention recommended casing:

uniform_group SomeGroup {
	// ...
}

Or:

uniform_group some_group {
	// ...
}

I'd go for snake_case personally, as the editor's automatic capitalization will probably do a better job with it.

I'd prefer PascalCase as that way it doesn't look like a keyword

edit: actually I guess it's not that bad with syntax highlighting

[paddy-exe]

We should probably update the shader style guide to mention recommended casing:

uniform_group SomeGroup {
	// ...
}

Or:

uniform_group some_group {
	// ...
}

I'd go for snake_case personally, as the editor's automatic capitalization will probably do a better job with it.

I am definitely in favor of snake_case because many (myself included) are already used to the automatic capitalization Godot does with the uniform properties.

[reduz]

I suggest something like:

group_uniforms Something; // Something
group_uniforms Something.Subgroup; // Something/Subgroup

group_uniforms; // No group

[paddy-exe]

I suggest something like:

group_uniforms Something; // Something
group_uniforms Something.Subgroup; // Something/Subgroup

group_uniforms; // No group

@reduz Do you mean that the grouped shader uniforms are between the group_uniforms statements?
I feel like that could be confusing compared to the example by @Chaosus

[Chaosus]

@reduz Alright - I did it as you said:

[akien-mga]

Approved in PR review meeting.

We're not all convinced by the implemented syntax, and some more discussion might be warranted to see what's the best syntax for this (taking into account that shaders don't have strings), but the feature implementation itself is good.

So we'll merge this now to have the feature and we can still change the syntax before 4.0 beta if we get a better suggestion.

[akien-mga]

Thanks!

[ArseniyMirniy]

Can this be done in Visual Shaders already? (maybe I'm missing something)