Clamp Decal size to positive values #61492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should also change the hint. And then IMO it can throw an error instead of clamping manually, so it doesn't change things without the user being aware when setting invalid values from code. |
Last time I tried, property range hints don't work for Vector properties (this affects min, max and step). |
|
Should be fine for the time being, but needs a rebase as As for range hints for vector properties, this could maybe be implemented for 4.1. @Sauermann opened a proposal about it: godotengine/godot-proposals#6260 |
Calinou
changed the title
|
Rebased and tested again, it works as expected. I've also added a bit of documentation regarding decal size (culling efficiency). |
Calinou
force-pushed
the
decal-clamp-extents
branch
2 times, most recently
from
4264f76 to
067a0e1
Compare
This prevents using negative size, while also preventing error messages from being spammed if one of the decal's dimensions is set to exactly 0.
Calinou
force-pushed
the
decal-clamp-extents
branch
from
067a0e1 to
8b1de10
Compare
akien-mga
approved these changes
Feb 13, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents using negative size, while also preventing error messages from being spammed if one of the decal's dimensions is set to exactly 0.
This closes #61491.