Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Show tooltips even when paused or time_scale is 0 #55224

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 22, 2021

Backport of #43693

@KoBeWi KoBeWi added this to the 3.5 milestone Nov 22, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner November 22, 2021 11:54
@akien-mga akien-mga merged commit c3606a8 into godotengine:3.x Nov 22, 2021
@KoBeWi KoBeWi deleted the ΔV_even_when_paused branch November 22, 2021 13:10
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

@golddotasksquestions
Copy link

golddotasksquestions commented Nov 26, 2021

I just tested this in Godot 3.4.1 rc1 and it does not work as I would expect.

Even if the whole scene tree is paused, including the control, the tool tip still shows up. I would expect the tooltip to only show up on the Control nodes which are processed (pause mode: Process), or inherit the pause mode from a processing Node (pause mode: Inherit).

However currently the tooltip shows up regardless of any pause setting.
This gives the user the same lack of control as hiding all tooltips by default.

image

Imagine you have a pause menu and you spawn it on top of your game with your game UI. The game and it's UI should be paused, but the pause menu should be processed. With this current implementation, the tooltips of the game UI would still show up. Even though all the user only would want the processed Controls to have tooltips.

Another issue I just noticed is how the tooltips appear at some offset location if there is a translated Camera2D in the scene. Not sure if this is a new issue or not since it is the first time I notice it:

tooltip_offset.mp4

I also just noticed the Control mouse filter "pass" has no effect on the tooltip. It will behaves identical to "stop".
"Stop" and "Ignore" behave exactly like you would expect: The top Control nodes tooltip shows up everwhere if it has "stop" mouse filter, and it does not show up if mouse filter is set to "ignore".
However "pass" just mimics "spot" behaviour, while I would expect the tooltip from the Control below to show up when the top Control has the "pass" mouse filter and I hover with my mouse over both. If the top has "pass" mouse filter, it should only show up in the region where there is no other Control tooltip below it. And in regions where there is a Control with tooltip below it, either both tooltips should show up or just the bottom one. However as it currently is "pass" has no purpose (possible similarities to #54529 ?)

Control Tooltip with mouse filter "pass" behaves like mouse filter "stop":

tooltip_pass.mp4

I can open up new bug issues for these, if desired.

@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 27, 2021

@golddotasksquestions
You can open an issue about tooltip pause. For pass/stop too if there isn't one already. The camera bug is fixed in 4.0 (#11732)

@golddotasksquestions
Copy link

golddotasksquestions commented Nov 29, 2021

@KoBeWi
I opened separate issues here:
#55428
#55430
#55432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants