Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doctool: Fix differences between headless and Vulkan rendering backends, run on CI in headless mode #54027

Merged
merged 2 commits into from
Oct 20, 2021
Merged

doctool: Fix differences between headless and Vulkan rendering backends, run on CI in headless mode #54027

merged 2 commits into from
Oct 20, 2021

Conversation

akien-mga
Copy link
Member

Fixes #53913.

@akien-mga akien-mga added this to the 4.0 milestone Oct 20, 2021
@akien-mga akien-mga requested review from a team as code owners October 20, 2021 14:39
@akien-mga akien-mga requested a review from qarmin October 20, 2021 14:43
@akien-mga
Copy link
Member Author

This actually breaks initialization:

ERROR: Property not found: rendering/vulkan/staging_buffer/block_size_kb
   at: _get (core/config/project_settings.cpp:244)
ERROR: Property not found: rendering/vulkan/staging_buffer/max_size_mb
   at: _get (core/config/project_settings.cpp:244)
ERROR: Property not found: rendering/vulkan/staging_buffer/texture_upload_region_size_px
   at: _get (core/config/project_settings.cpp:244)
ERROR: Property not found: rendering/vulkan/descriptor_pools/max_descriptors_per_pool
   at: _get (core/config/project_settings.cpp:244)

@akien-mga akien-mga marked this pull request as draft October 20, 2021 15:42
@akien-mga akien-mga marked this pull request as ready for review October 20, 2021 16:31
@akien-mga akien-mga merged commit 160d590 into godotengine:master Oct 20, 2021
@akien-mga akien-mga deleted the doctool-headless branch October 20, 2021 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qarmin qarmin qarmin approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:buildsystem topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Headless doctool run generate different docs than normal run
2 participants
@akien-mga @qarmin