Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More fixes to mobile renderer #51843

Merged
merged 1 commit into from
Aug 18, 2021
Merged

More fixes to mobile renderer #51843

merged 1 commit into from
Aug 18, 2021
+125 −108

Conversation

reduz
Copy link
Member

@reduz reduz commented Aug 18, 2021

  • Specify all precision qualifiers
  • Makes renderer work on Adreno Vulkan

@reduz
More fixes to mobile renderer
700f9d9 
* Specify all precision qualifiers
* Makes renderer work on Adreno Vulkan
@reduz reduz requested a review from a team as a code owner August 18, 2021 15:23
@akien-mga akien-mga added this to the 4.0 milestone Aug 18, 2021
clayjohn
clayjohn approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me.

I had a concern about adding precision qualifiers to sampler** types, however, reduz explained that it is perfectly legal in GLSL to add a precision qualifier to uniform samplers.

This is ready to merge whenever

@akien-mga akien-mga merged commit f6626a4 into godotengine:master Aug 18, 2021
@akien-mga
Copy link
Member

Thanks!

@Geometror Geometror mentioned this pull request Jan 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@reduz @akien-mga @clayjohn