Fix BBCode tables overlap with bottom text (Fix #47012) #47050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #47012
Issue :
In RichTextLabel, text after a [table] element overlaps with table last row if the last row doesn't use all columns.
Before :
Fix proposal :
The height of the row was only added if
column == col_count - 1
=> if all the columns was used.I've added an other condition :
(column == col_count - 1 || E->next() == nullptr)
=> if all the columns was used OR if it's the last element of the table (even if it's not on the last column).After :