Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SafeNumeric::conditional_increment() for NO_THREADS #46424

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Fix SafeNumeric::conditional_increment() for NO_THREADS #46424

merged 1 commit into from
Feb 25, 2021

Conversation

RandomShaper
Copy link
Member

Fixes #46352.

@RandomShaper RandomShaper added bug topic:core cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Feb 25, 2021
@RandomShaper RandomShaper added this to the 4.0 milestone Feb 25, 2021
@RandomShaper RandomShaper requested a review from a team as a code owner February 25, 2021 20:23
Faless
Faless approved these changes Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I confirm this fixes the NO_THREADS issue 🏅 .

@akien-mga akien-mga merged commit f3f6c62 into godotengine:master Feb 25, 2021
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_no_threads branch February 25, 2021 21:32
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 25, 2021
@akien-mga akien-mga mentioned this pull request Mar 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Faless Faless Faless approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

HTML5 Export broken in 3.2.4RC3 (function signature mismatch)
3 participants
@RandomShaper @akien-mga @Faless