-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RenderingServer reorganization #44094
Conversation
I don't really know how this worked before, but out of curiosity in my ignorance, why is there no RenderingDeviceGLES3? |
3643400
to
00a37bb
Compare
I like the rename. "raster" -> "render" seems appropriate. |
@Riteo RenderingDevice is an abstraction layer of moder graphics APIs (Vulkan/DX12/etc.) so GLES3 doesn't really fit in. Instead, we will have separate renderer implementation that directly interacts with GLES3. |
Just to voice a little dissent 😄 I still have a suspicion these new names may prove to be overly long. Using the word Namespaces, or prefixes if avoiding namespaces - like Rs for RenderingServer and Rd for Rendering Device could be an option if wanting to include extra information. I'm not sure adding the word server to the names adds that much useful info to outweigh the verbosity etc. |
00a37bb
to
e38945a
Compare
@lawnjelly done, we thought about the same with @JFonS, so changed the names per your suggestion. |
ebeb851
to
d9b2609
Compare
d9b2609
to
2787ad6
Compare
This PR reorganizes and renames most of RenderingServer classes in hopes that it's easier to understand them. Following diagram shows what each is: