Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CanvasGroup and CanvasItem clipping #43167

Merged
merged 2 commits into from
Oct 29, 2020
Merged

Implement CanvasGroup and CanvasItem clipping #43167

merged 2 commits into from
Oct 29, 2020

Conversation

reduz
Copy link
Member

@reduz reduz commented Oct 28, 2020

  • Allows merging several 2D objects into a single draw operation
  • Use current node to clip children nodes
  • Further fixes to Vulkan barriers
  • Changed font texture generation to white, fixes dark eges when blurred
  • Other small misc fixes to backbuffer code.

mask
cgroup1
clip

@akien-mga akien-mga added this to the 4.0 milestone Oct 28, 2020
akien-mga
akien-mga reviewed Oct 28, 2020
View reviewed changes
scene/main/canvas_item.h Outdated Show resolved Hide resolved
akien-mga
akien-mga approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a quick read and pinpointed some potential code quality fixes.
Giving it OK already anyway as it seems mostly good to merge, so it can be merged while I sleep ;)

@reduz
Implement CanvasGroup and CanvasItem clipping
8ab9b39 
-Allows merging several 2D objects into a single draw operation
-Use current node to clip children nodes
-Further fixes to Vulkan barriers
-Changed font texture generation to white, fixes dark eges when blurred
-Other small misc fixes to backbuffer code.
@Calinou Calinou mentioned this pull request Oct 28, 2020
Merged
@reduz @Calinou
Update scene/resources/dynamic_font.cpp
a65481d 
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
@reduz reduz merged commit 50da616 into godotengine:master Oct 29, 2020
@akien-mga
Copy link
Member

akien-mga commented Oct 29, 2020 •
edited
Loading

An "Update $filename" commit and it's not even Halloween yet 🙀

@Zireael07
Copy link
Contributor

Vulkan only or is that for GLES too?

@Calinou
Copy link
Member

Calinou commented Oct 30, 2020

@Zireael07 Given how this relies on low-level rendering changes, I doubt this can be reimplemented in GLES3 or GLES2 efficiently.

@Calinou Calinou mentioned this pull request Oct 31, 2020
Open
@Calinou Calinou mentioned this pull request Nov 9, 2020
Closed
@clayjohn clayjohn mentioned this pull request Nov 28, 2020
Closed
This was referenced Jan 31, 2021
Closed
Closed
@Calinou Calinou mentioned this pull request Feb 4, 2021
Closed
@Poobslag Poobslag mentioned this pull request Apr 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn left review comments

@Calinou Calinou Calinou left review comments

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
feature proposal topic:core topic:rendering
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@reduz @akien-mga @Zireael07 @Calinou @clayjohn