Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in test args #40930

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Fix memory leak in test args #40930

merged 1 commit into from
Jul 31, 2020

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Jul 31, 2020

With the #40928, this allows #40920 to pass the tests with sanitizer.

==24982==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 47 byte(s) in 2 object(s) allocated from:
    #0 0x7fa785b20618 in operator new[](unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.4+0xe0618)
    #1 0x1bac644 in test_main(int, char**) tests/test_main.cpp:76
    #2 0x1a55116 in Main::test_entrypoint(int, char**, bool&) main/main.cpp:380
    #3 0x1973940 in main platform/linuxbsd/godot_linuxbsd.cpp:45
    #4 0x7fa782ad1b96 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b96)

SUMMARY: AddressSanitizer: 47 byte(s) leaked in 2 allocation(s).

P.S. My first bug fix with sanitizer's help. 😛

@bruvzg bruvzg added this to the 4.0 milestone Jul 31, 2020
@akien-mga akien-mga merged commit bc813fd into godotengine:master Jul 31, 2020
@akien-mga
Copy link
Member

Thanks!

@Xrayez Xrayez deleted the fix-leak-test-args branch July 31, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants