-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux sanitizer build to github workspace to test tests and editor #40920
Conversation
There are still memory leaks even after #40921 is fixed, I think this requires minimal initialization of core and proper deinit of (probably implicitly initialized) objects, but in any case this signifies that there are certain initialization dependencies which could be either fixed in core or make sure that the test runner initializes stuff in a way to ensure the rest of the testing goes smooth. But I'm not sure, perhaps the test runner should be actually be called somewhere in |
Actually there was just one thing left which blocked this: #40930. What I've said above came from me trying to |
0806702
to
081e72a
Compare
Managed to port |
b3fdda7
to
8f754f0
Compare
8f754f0
to
2fec1b9
Compare
Thanks! |
|
||
# Upload cache on completion and check it out now | ||
- name: Load .scons_cache directory | ||
id: linux-editor-cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged too fast, this is going to corrupt the cache since both Linux editor builds share the same id/keys.
We need to test tests because no one need untested tests which results are unpredictable ¯\_(ツ)_/¯
Additionally this build with address(which contains also leak sanitizer on Linux by default) and undefined sanitizer would be really good to run and test editor by xvfb-run tool when GLES 2 will be available.
This will prevent from a lot of bugs which were hidden to end users by default like #40848.