Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write AndroidManifest.xml file for Gradle project #40610

Merged
merged 1 commit into from
Jul 24, 2020
Merged

Write AndroidManifest.xml file for Gradle project #40610

merged 1 commit into from
Jul 24, 2020

Conversation

amanj120
Copy link
Contributor

This is a forward port of #40609

@akien-mga @m4gr3d tagging you for visibility.

@Calinou Calinou added this to the 4.0 milestone Jul 22, 2020
@amanj120 amanj120 force-pushed the forward_port_bundle_pr_manifest branch 2 times, most recently from 52511c7 to 506cc19 Compare July 23, 2020 16:16
@m4gr3d m4gr3d self-requested a review July 23, 2020 16:17
m4gr3d
m4gr3d requested changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly good first pass!

The comments are mostly about code layout; the core logic looks good!

platform/android/export/export.cpp Show resolved Hide resolved
platform/android/export/export.cpp Show resolved Hide resolved
platform/android/export/export.cpp Outdated Show resolved Hide resolved
platform/android/export/export.cpp Outdated Show resolved Hide resolved
platform/android/export/export.cpp Outdated Show resolved Hide resolved
platform/android/export/export.cpp Outdated Show resolved Hide resolved
platform/android/export/gradle_export_util.h Show resolved Hide resolved
m4gr3d
m4gr3d requested changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost done; just one minor feedback to address.

platform/android/export/export.cpp Show resolved Hide resolved
platform/android/export/gradle_export_util.h Show resolved Hide resolved
@amanj120 amanj120 force-pushed the forward_port_bundle_pr_manifest branch 2 times, most recently from 6e2b344 to 967a067 Compare July 24, 2020 16:51
@amanj120 amanj120 force-pushed the forward_port_bundle_pr_manifest branch from 967a067 to e53067c Compare July 24, 2020 16:53
m4gr3d
m4gr3d approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@m4gr3d m4gr3d requested review from akien-mga and a team July 24, 2020 17:22
@akien-mga akien-mga merged commit 963d3a0 into godotengine:master Jul 24, 2020
@akien-mga
Copy link
Member

Thanks!

@amanj120 amanj120 deleted the forward_port_bundle_pr_manifest branch July 24, 2020 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@akien-mga akien-mga Awaiting requested review from akien-mga

Assignees
No one assigned
Labels
enhancement platform:android topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amanj120 @akien-mga @m4gr3d @Calinou