Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash when shader inputs/outputs is invalid string #34240

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

timothyqiu
Copy link
Member

This fixes #29985

  • More array size checks after spliting the inputs/outputs string

@Chaosus Chaosus added this to the 3.2 milestone Dec 10, 2019
@akien-mga akien-mga merged commit 74381c3 into godotengine:master Dec 11, 2019
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the invalid-shader-io-29985 branch December 11, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crash when using VisualShaderNodeGroupBase::set_output_port_name(int, String const&)
3 participants