Add an "Auto" editor font hinting setting to match OS font rendering #31375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Aug 14, 2019
akien-mga
reviewed
Aug 14, 2019
The "Auto" setting picks the font hinting setting that best matches the operating system's font rendering settings. This font hinting setting is now the default.
Calinou
force-pushed
the
add-auto-editor-font-hinting
branch
from
5205593
to
c940d29
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Auto" setting picks the font hinting setting that best matches the operating system's font rendering settings. This font hinting setting is now the default to provide better integration with the OS.
I've also considered exposing this as a setting in DynamicFontData so that it can be used in projects, but this would break compatibility, so it'd have to wait for 4.0. Besides, adjusting font hinting to match the OS is usually not desired in games. It'd still be nice to have in non-game applications though.
We could have more accurate detection on Linux using X11 APIs (since hinting is configurable there), but I don't know how to do this. If it doesn't require too much code, help would be appreciated here 🙂
PS: I've chosen "Light" hinting on Windows, but maybe "Normal" matches ClearType rendering more?
Preview
Before (all platforms)
After (on macOS)
After (on Linux and Windows)