Properly disable SIGPIPE on OSX/iOS network sockets.#30158
Merged
akien-mga merged 2 commits intogodotengine:masterfrom Jun 29, 2019
Merged
Properly disable SIGPIPE on OSX/iOS network sockets.#30158akien-mga merged 2 commits intogodotengine:masterfrom
akien-mga merged 2 commits intogodotengine:masterfrom
Conversation
Faless
changed the title
Disable SO_NOSIGPIPE socket option when avaiable. Use MSG_NOSIGNAL send flag on systems that support it.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable SO_NOSIGPIPE socket option via
setsockoptwhen avaiable.Use MSG_NOSIGNAL send flag on systems that support it.
Also include an header inclusion order change to fix build on OpenBSD after #29935 .
As always, I run quire a few builds on various OSes, but I can't really test on OSX. So testers are welcome.