Multicast, more network interfaces info#29935
Merged
akien-mga merged 2 commits intogodotengine:masterfrom Jun 21, 2019
Merged
Conversation
Allow getting interfaces names and assigned names. On UWP this is not supported, and the function will return one interface for each local address (with interface name the local address itself).
8276bfb to
e5e3f86
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
get_local_interfacesmethod returns informations about network cards (names, ips)join/leave_multicast_groupmethods inPacketPeerUDP.In the future, adding a single source (and blocking a source) could be similarly supported.
Test project (run on multiple machines, same network. Unless firewall blocks, should work).
Tested Win<->Android, Linux<->Android, and compiles on *BSD too. UWP does not really support getting interfaces in all its variants, so for now it returns a fake interfaces for each ip addresses discovered via
GetHostNames.