Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Basis values now marshalled in the correct order. #16326

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

NathanWarden
Copy link
Contributor

The values being passed into Transform's Basis from cpp to Mono were in the wrong order so things like rotations and Transform.basis.z wouldn't work properly.

This fixes that. Can provide examples if needed :)

@Benjamin-Dobell
Copy link
Contributor

Pertains to #11901

@27thLiz 27thLiz added this to the 3.1 milestone Feb 2, 2018
@NathanWarden
Copy link
Contributor Author

I have an extra change I need to push up, it looks like the Basis.cs itself was also in the wrong order. I have a test suite I'm building and will comment here again when I've verified everything is the same as GDScript :)

@NathanWarden
Copy link
Contributor Author

@akien-mga akien-mga requested a review from neikeq February 12, 2018 08:17
@akien-mga
Copy link
Member

Fixes the Mono part of #14553 I believe.

@NathanWarden
Copy link
Contributor Author

Looking at the code of the last example project in that thread this should fix that issue :)

LinearVelocity = Transform.basis.z * 10f;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants