Skip to content

Revert "FTI - Reduce VisualInstance3D xform notifications" #107854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Revert "FTI - Reduce VisualInstance3D xform notifications" #107854

merged 1 commit into from
Jun 22, 2025

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 22, 2025 •
edited by akien-mga
Loading

This reverts commit e10003c / #105901.

Fixes #107829
Fixes #107755

Notes

  • There appear more cases where NOTIFICATION_TRANSFORM_CHANGED inherited from VisualInstance are used in 4.x than 3.x (where forward ported from)
  • I'll revisit this in 3.x / 4.6 to see if we can reduce these without causing regressions, it's not critical for 4.5.

@lawnjelly lawnjelly added this to the 4.5 milestone Jun 22, 2025
@lawnjelly lawnjelly requested a review from a team as a code owner June 22, 2025 14:51
@akien-mga akien-mga merged commit 8affc4c into godotengine:master Jun 22, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@simpkins simpkins mentioned this pull request Jun 23, 2025
Closed
@lawnjelly lawnjelly mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

bug regression topic:rendering topic:3d

Projects

None yet

Milestone

4.5

Development

Successfully merging this pull request may close these issues.

SoftBody3D broken in 4.5-beta1 Weird Softbody behaviour with Area3D wind when physics interpolation is off

2 participants

@lawnjelly @akien-mga