SceneTreeFTI - Fix identity_xform flag getting out of sync
#107041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could cause incorrect rendered xform for one frame.
akien-mga
approved these changes
Jun 2, 2025
akien-mga
changed the title
SceneTreeFTI - fix identity_xform flag getting out of syncSceneTreeFTI - Fix identity_xform flag getting out of sync
rburing
approved these changes
Jun 2, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could cause incorrect rendered xform for one frame.
Fixes #107019
This bug was caused by the
fti_is_identity_xformflag getting out of sync - the transform was checked against the identity xform before the new xform was set.The solution was to move the notification code to after the xform had been set in each case.
Notes