Add warning when system font fallback is used. #107016
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Jun 3, 2025
Comment on lines
+684
to
+686
| <member name="debug/settings/ui/show_system_font_fallback_warnings" type="int" setter="" getter="" default="1"> | ||
| If enabled, produces a warning when system font fallback is used. | ||
| </member> |
There was a problem hiding this comment.
The enum setting can be replaced with just a boolean that defaults to false, and is overridden to true for the editor_runtime feature tag.
Calinou
reviewed
Jun 3, 2025
There was a problem hiding this comment.
Tested locally, it works as expected.
I agree about having a project setting to disable it, since there are many cases where the warning isn't relevant (non-game applications, or demos like BiDi and Font Features).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds warning displayed when system fallback font is used, warning can be disabled from the project settings, only enabled for debug builds, and by default is displayed only when running from editor with attached debugger. It is not displayed when system fonts are used directly (using
SystemFontclass).Warning include used system font and text string that triggered it (without duplication):
System font fallback is useful, but is a constant source of confusion, since different platforms have different fallback capabilities and sets of available fonts.
See following issues for example, there are multiple other similar issues:
#106824
#84590
#78921
#77903