Skip to content

Conversation

BlueCube3310
Copy link
Contributor

Follow-up to #106437

The code for detecting the resulting channel configuration operated under the assumption that each color channel that was part of said configuration had to be present in an image.
This is the most common scenario, but the channel remapping feature made the issue more likely to come across.

Now, the configurations are selected based on the presence of the outermost channel. (i.e. A -> RGBA, B -> RGB, G -> RG, R-> R).

@BlueCube3310 BlueCube3310 requested review from a team as code owners May 16, 2025 10:57
@BlueCube3310 BlueCube3310 added this to the 4.x milestone May 16, 2025
@akien-mga akien-mga modified the milestones: 4.x, 4.5 May 16, 2025
@fire fire requested review from a team May 16, 2025 18:01
@fire
Copy link
Member

fire commented May 16, 2025

I think this is a good change, but I can't review it in depth now. Consider this approval.

@Repiteo Repiteo merged commit a2aefab into godotengine:master May 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented May 19, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants